Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress doc clarifications #16932

Merged
merged 1 commit into from
Nov 8, 2015
Merged

Conversation

bprashanth
Copy link
Contributor

Last minute doc clarifications. Assigning to Jeff since he has context, feel free to re-assign.


Before you can receiver traffic through the GCE L7 Loadbalancer Controller you need:
* A Working Kubernetes 1.1 cluster
* At least 1 Kubernets [NodePort service](../../../../docs/user-guide/services.md#type-nodeport) (this is the endpoint for your Ingress)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Kubernets/Kubernetes

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 6, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 6, 2015

GCE e2e test build/test passed for commit a7752bed9db084c914bb8fe48fc78521ad471f75.

@j3ffml
Copy link
Contributor

j3ffml commented Nov 6, 2015

lgtm, thanks

@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2015
@bprashanth
Copy link
Contributor Author

Added a line about HTTPS, re-adding lgtm to keep merge bot happy

@bprashanth bprashanth added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 6, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 6, 2015

GCE e2e test build/test passed for commit d4d0addb6e10569df783f68be61a36689e109a14.

@k8s-bot
Copy link

k8s-bot commented Nov 6, 2015

GCE e2e build/test failed for commit 10d1d4c.

@bprashanth
Copy link
Contributor Author

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Nov 6, 2015

GCE e2e build/test failed for commit 10d1d4c.

@bprashanth
Copy link
Contributor Author

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Nov 6, 2015

GCE e2e test build/test passed for commit 10d1d4c.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Nov 7, 2015

GCE e2e build/test failed for commit 10d1d4c.

@bprashanth
Copy link
Contributor Author

Jenkins flakes are unrelated, shippable and unittests passed, merging manually for release

bprashanth added a commit that referenced this pull request Nov 8, 2015
@bprashanth bprashanth merged commit 17c5c09 into kubernetes:master Nov 8, 2015
k8s-github-robot referenced this pull request Nov 8, 2015
…6932-upstream-release-1.1

Auto commit by PR queue bot
shyamjvs referenced this pull request in shyamjvs/kubernetes Dec 1, 2016
…pick-of-#16932-upstream-release-1.1

Auto commit by PR queue bot
shouhong referenced this pull request in shouhong/kubernetes Feb 14, 2017
…pick-of-#16932-upstream-release-1.1

Auto commit by PR queue bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants